[sqlite3] disable find_package for ICU when SQLITE_ENABLE_ICU is not …#52613
[sqlite3] disable find_package for ICU when SQLITE_ENABLE_ICU is not …#52613Willieodwyer wants to merge 2 commits into
Conversation
BillyONeal
left a comment
There was a problem hiding this comment.
This seems like a reasonable change but you need to bump port-version and run x-add-version sqlite3
b836fc2 to
d7c1d63
Compare
|
@Willieodwyer please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
@microsoft-github-policy-service agree |
Done. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| endif() | ||
| if("@VCPKG_LIBRARY_LINKAGE@" STREQUAL "static") | ||
| if("@SQLITE_ENABLE_ICU@" AND "@VCPKG_LIBRARY_LINKAGE@" STREQUAL "static") | ||
| find_package(ICU COMPONENTS uc i18n) |
There was a problem hiding this comment.
Nitpick: with proper guards, this can become
| find_package(ICU COMPONENTS uc i18n) | |
| find_dependency(ICU COMPONENTS uc i18n) |
…enabled
./vcpkg x-add-version --alland committing the result.This fixes a significant slowdown caused by
find_package(ICU COMPONENTS uc i18n)looking for ages for libraries that aren't there